[xmonad] mupdf and llpp return from fullscreen

[Carsten Mattner]

On Tue, Jun 26, 2012 at 11:17 PM, Audun Skaugen <audunskaugen at gmail.com> wrote:
> På Tue, 26 Jun 2012 23:04:38 +0200, skrev Carsten Mattner
> <carstenmattner at googlemail.com>:
>
>
>> On Tue, Jun 26, 2012 at 10:57 PM, Audun Skaugen <audunskaugen at gmail.com>
>> wrote:
>>>
>>> På Tue, 26 Jun 2012 22:48:41 +0200, skrev Carsten Mattner
>>> <carstenmattner at googlemail.com>:
>>>
>>>
>>>> See below for links to the fullscreen code in mupdf.
>>>>
>>>> generic code calling winfullscreen():
>>>>
>>>>
>>>> http://git.ghostscript.com/?p=mupdf.git;a=blob;f=apps/pdfapp.c;h=d2c28927;hb=HEAD#l789
>>>>
>>>> X11 winfullscreen():
>>>>
>>>>
>>>> http://git.ghostscript.com/?p=mupdf.git;a=blob;f=apps/x11_main.c;h=941afcfa;hb=HEAD#l325
>>>>
>>>> This might explain why mupdf works with EwmhDesktops's fullscreen
>>>> hooks but not Layout.Fullscreen's.
>>>
>>>
>>>
>>> My bad, I assumed ubuntu had a recent enough version. I'll look at this
>>> and
>>> see if I what I can do.
>>
>>
>> Building the git clone is simple. Get the thirdparty zip and extract it
>> in the tree. After that simply run 'make build=release'.
>>
>> To be clear, EwmhDesktops makes mupdf's fullscreen work.
>> Once Layout.Fullscreen support fullscreening mupdf does it
>> mean that returning from fullscreen should prevent mupdf
>> getting tiled?
>>
>> This is all independent of the mplayer move by border width issue, isn't
>> it?
>>
>> Thanks for the help.
>
>
> It was indeed easy to build a newer mupdf, and with this fullscreening works
> a charm with both ewmhDesktops hook and the Layout.Fullscreen module. Having
> an app to play with also made wonders. I realize the problem!
>
> You were of course trying to fullscreen a floating window. I should have
> thought of this at once, but this is not supported by the fullscreenFull
> modifier. To get this behaviour, you also need the fullscreenFloat modifier,
> which is left out from the default because its implementation is kind of
> hacky. I'll try to make the documentation be more explicit about this (but
> not before I come back from holiday ;)
>
> I attached a minimalish example config that makes it work, an has your
> desired behaviour of returning floating fullscreened windows to floating.
>
> You are also right about this being independent from the mplayer issue.

Thanks that seems to work for mupdf (and llpp).
Do you plan to add the missing support to Layout.Fullscreen and
remove the need for partially importing EwmhDesktops?

I don't even seem to require the  isFullscreen -->
fullscreenManageHook or doFullFloat rule.

I didn't manage to add a doFloat rule for llpp but when I make
it manually floating by moving the window with the mouse
and go fullscreen and back by holding 'f' pressed it seems to
somehow forget the size or not manage to act fast enough
because llpp is more heavy on redrawing the window.
Does that make any sense? It happens that llpp's window
can be made zoomed or or too big on return rom fullscreen
if you do it repeatedly by holding 'f' pressed. mupdf doesn't
have that problem. This is not as important but maybe it's
useful for you.