[xmonad] darcs patch: Add windowRemover for make tabbed return just the focu...

Don Stewart dons at galois.com
Fri Feb 1 20:44:58 EST 2008


sjanssen:
> On Fri, Feb 01, 2008 at 12:02:04PM +0100, Andrea Rossato wrote:
> > Hi,
> > 
> > this is a follow up of the discussion with Spencer about tabbed.
> > 
> > This patch implements WindowRemover. If placed over tabbed it should
> > be removing unfocused windows, without touching the windows
> > decoration.
> > 
> > WARNING: while this patch passes all tests both with ghc-6.6.1 and
> > ghc-6.8.2, when I build this test file:
> > import XMonad
> > import XMonad.Config.Arossato
> > main = xmonad =<< arossatoConfig
> > 
> > ghc-6.6.1 fails with this linker error:
> > [12:00:33][wolf at laptop:~/.xmonad]$ ghc --make xmonad.hs
> > Linking xmonad ...
> > /usr/local/lib/xmonad-contrib-0.6/ghc-6.6.1/libHSxmonad-contrib-0.6.a(Combo.o): In function `s1e0s_info':
> > ghc3557_0.hc:(.text+0x3ada): undefined reference to `xmonadzmcontribzm0zi6_XMonadziLayoutziWindowNavigation_zdf3_info'
> > /usr/local/lib/xmonad-contrib-0.6/ghc-6.6.1/libHSxmonad-contrib-0.6.a(Combo.o):(.rodata+0xa8): undefined reference to `xmonadzmcontribzm0zi6_XMonadziLayoutziWindowNavigation_zdf3_closure'
> > collect2: ld returned 1 exit status
> > 
> > The same code compiles, and works perfectly (unless bugs introduced by
> > its author, me) on ghc-6.8.2.
> > 
> > This is why I'd like someone to test it (I'll include it also in the
> > bug tracker).
> > 
> > Cheers,
> > Andrea
> > 
> > Fri Feb  1 11:55:05 CET 2008  Andrea Rossato <andrea.rossato at unibz.it>
> >   * Add windowRemover for make tabbed return just the focused window
> 
> I think this solution is *really* ugly.  Also, I don't think we can
> necessarily rely on the property that decorations windows are the only
> override-redirect windows in the windowset.

That sounds fragile.


More information about the xmonad mailing list