[ghc-steering-committee] Please review #516: Introduce `-Wincomplete-record-selectors`, Shepherd: Eric

Spiwack, Arnaud arnaud.spiwack at tweag.io
Wed Aug 24 05:47:40 UTC 2022


The proposal makes sense to me. I don't have a strong opinion, but I'm
leaning towards acceptance.

On Tue, Aug 23, 2022 at 8:14 PM Eric Seidel <eric at seidel.io> wrote:

> Dear Committee,
>
> Adam Gundry has proposed a new warning -Wincomplete-record-selectors[1]
> that would flag occurrences of partial record selectors, e.g. the field `x`
> in
>
> ```
> data T = T1 { x :: Int, y :: Bool }
>        | T2 { y :: Bool }
> ```
>
> The proposal is well-specified, will never warn about total selectors
> (e.g. `y` above), and allows for a smarter compiler to suppress warnings in
> cases where a partial selector is used in a total context (e.g. `x (T1 42
> True)`).
>
> I recommend acceptance.
>
> [1]: https://github.com/ghc-proposals/ghc-proposals/pull/516
>
> On Sun, Aug 14, 2022, at 13:01, Joachim Breitner wrote:
> > Dear Committee,
> >
> > Introduce `-Wincomplete-record-selectors`
> > have been submitted by Adam Gundry
> >
> > https://github.com/ghc-proposals/ghc-proposals/pull/516
> >
> https://github.com/adamgundry/ghc-proposals/blob/incomplete-record-selectors/proposals/0000-incomplete-record-selectors.rst
> >
> > I suggest that Eric shepherds this proposal.
> >
> > Please guide us to a conclusion as outlined in
> > https://github.com/ghc-proposals/ghc-proposals#committee-process
> >
> > Thanks,
> > Joachim
> >
> > --
> > Joachim Breitner
> >   mail at joachim-breitner.de
> >   http://www.joachim-breitner.de/
> >
> > _______________________________________________
> > ghc-steering-committee mailing list
> > ghc-steering-committee at haskell.org
> > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> _______________________________________________
> ghc-steering-committee mailing list
> ghc-steering-committee at haskell.org
> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-steering-committee/attachments/20220824/6e5868cc/attachment.html>


More information about the ghc-steering-committee mailing list