[GHC] #16348: GHC HEAD regression: tyConAppArgs

[Simon Peyton Jones]

Matthew, Ben

I've just received 40-odd messages like this one.  It looks as if Marge is now sending commit messages at Trac ticket messages, which is great.  Will that happen after the move to GitLab.

Also, is this sudden wave because a whole lot of commits have now landed in master?  Or is it somehow an old backlog stuck in a mail queue?

There may be some housekeeping to do, to close tickets, check regression tests and add pointers to the appropriate tests.  Is anyone up for doing that?

Thanks

Simon

| -----Original Message-----
| From: ghc-tickets <ghc-tickets-bounces at haskell.org> On Behalf Of GHC
| Sent: 04 March 2019 18:51
| Subject: Re: [GHC] #16348: GHC HEAD regression: tyConAppArgs
| 
| #16348: GHC HEAD regression: tyConAppArgs
| -------------------------------------+-------------------------------------
|         Reporter:  RyanGlScott       |                Owner:  (none)
|             Type:  bug               |               Status:  closed
|         Priority:  highest           |            Milestone:  8.10.1
|        Component:  Compiler          |              Version:  8.7
|       Resolution:  fixed             |             Keywords:
| Operating System:  Unknown/Multiple  |         Architecture:
|                                      |  Unknown/Multiple
|  Type of failure:  Compile-time      |            Test Case:
|   crash or panic                     |  simplCore/should_compile/T16348
|       Blocked By:                    |             Blocking:
|  Related Tickets:                    |  Differential Rev(s):
|        Wiki Page:                    |
| https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha
| skell.org%2Fghc%2Fghc%2Fmerge_requests%2F416&data=02%7C01%7Csimonpj%40m
| icrosoft.com%7C50e6bec9985e4121351808d6a0d2a90f%7C72f988bf86f141af91ab2d7cd
| 011db47%7C1%7C0%7C636873224010230414&sdata=SvX8wLsObYmasJTvB6yT9CQbxoFK
| ZkdGpv7ZHfDRqYs%3D&reserved=0
| -------------------------------------+-------------------------------------
| 
| Comment (by Matthew Pickering <matthewtpickering@…>):
| 
|  In [changeset:"c25b135ff5b9c69a90df0ccf51b04952c2dc6ee1/ghc"
|  c25b135f/ghc]:
|  {{{
|  #!CommitTicketReference repository="ghc"
|  revision="c25b135ff5b9c69a90df0ccf51b04952c2dc6ee1"
|  Fix exprIsConApp_maybe
| 
|  In this commit
|     commit 7833cf407d1f608bebb1d38bb99d3035d8d735e6
|     Date:   Thu Jan 24 17:58:50 2019 +0100
|        Look through newtype wrappers (Trac #16254)
| 
|  we made exprIsConApp_maybe quite a bit cleverer.  But I had not paid
|  enough attention to keeping exactly the correct substitution and
|  in-scope set, which led to Trac #16348.
| 
|  There were several buglets (like applying the substitution twice in
|  exprIsConApp_maybe, but the proximate source of the bug was that we were
|  calling addNewInScopeIds, which deleted things from the substitution as
|  well as adding them to the in-scope set.  That's usually right, but not
|  here!
| 
|  This was quite tricky to track down.  But it is nicer now.
|  }}}
| 
| --
| Ticket URL:
| <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske
| ll.org%2Ftrac%2Fghc%2Fticket%2F16348%23comment%3A7&data=02%7C01%7Csimon
| pj%40microsoft.com%7C50e6bec9985e4121351808d6a0d2a90f%7C72f988bf86f141af91a
| b2d7cd011db47%7C1%7C0%7C636873224010230414&sdata=Hmm1p52EqBpdLX1sFkutPm
| Z8hSjY%2FtzS1FZqlFYCxYI%3D&reserved=0>
| GHC
| <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.haske
| ll.org%2Fghc%2F&data=02%7C01%7Csimonpj%40microsoft.com%7C50e6bec9985e41
| 21351808d6a0d2a90f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63687322401
| 0230414&sdata=AuTz%2BM22brpeoXARiWrhvqlGd4w2myu1YNobnhj16L8%3D&rese
| rved=0>
| The Glasgow Haskell Compiler