GHC | Some refactoring in tcInferApps (!116)

Simon Peyton Jones simonpj at
Mon Jan 14 17:11:21 UTC 2019

Thanks.  But none of the pictures arrived, so I can’t interpret what you say.

I think I did see Richards face here and there (and mine), if that’s want avatars means. Hovering showed a snippet of a comment; but clicking did nothing.

I’m also terribly reluctant to scroll through thousands of lines of diff looking for avarars.


From: ghc-devs <ghc-devs-bounces at> On Behalf Of Sylvain Henry
Sent: 14 January 2019 16:21
To: ghc-devs at
Subject: Re: GHC | Some refactoring in tcInferApps (!116)

Hi Simon,

In the diff view, you can click on the avatars on the left to expand discussions:

[cid:part1.E17582DB.274298F8 at]

Or you can click on the "toggle comments for this file" button:

[cid:part2.D9953BB2.A74D4E27 at]

If you are willing to use GreaseMonkey (Firefox extension) or TamperMonkey (Chrome/Chromium extension), you can use the attached script to add new buttons to GitLab UI:

[cid:part3.9CF91D30.FC1AF3DA at]

[cid:part4.5144A0AF.98359F8A at]

Tested on Firefox and Chromium on Linux.


On 14/01/2019 11:58, Simon Peyton Jones via ghc-devs wrote:

|  (without the 'diff' at the end) you can see the collapsed discussion items?

Yes, in the discussion tab I can.  But of course that is out of context; you just get a little (non-expandable) snippet.


|  -----Original Message-----

|  From: Mikolaj Konarski <mikolaj at><mailto:mikolaj at>

|  Sent: 14 January 2019 10:30

|  To: Simon Peyton Jones <simonpj at><mailto:simonpj at>

|  Cc: ghc-devs <ghc-devs at><mailto:ghc-devs at>

|  Subject: Re: GHC | Some refactoring in tcInferApps (!116)


|  > Looking here

|  >

|  >

|  >

|  > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda

|  > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0

|  > I see literally NO discussions with a "toggle discussion" button.  Indeed

|  if I search for "toggle" I get no hits.


|  Oh, I see, you are right with respect to the link you cited now.

|  None of the buttons help, just as you say. I have to navigate back from the

|  "Changes" to the "Discussion" tab, which gets me to the link you gave

|  initially

|  (



|  d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm

|  4ag7%2BqBi3c4qpAE7sE%3D&reserved=0)

|  where the discussions are available, but I can't see them in the context of

|  the whole diff and none of the buttons there let me extend the view of the

|  diff. That's quite suboptimal.


|  Could you confirm that at





|  011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4

|  ag7%2BqBi3c4qpAE7sE%3D&reserved=0


|  (without the 'diff' at the end) you can see the collapsed discussion items?


ghc-devs mailing list

ghc-devs at<mailto:ghc-devs at><>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the ghc-devs mailing list