GHC | Some refactoring in tcInferApps (!116)

[Sylvain Henry]

Hi Simon,

In the diff view, you can click on the avatars on the left to expand 
discussions:

Or you can click on the "toggle comments for this file" button:



If you are willing to use GreaseMonkey (Firefox extension) or 
TamperMonkey (Chrome/Chromium extension), you can use the attached 
script to add new buttons to GitLab UI:


Tested on Firefox and Chromium on Linux.

Sylvain




On 14/01/2019 11:58, Simon Peyton Jones via ghc-devs wrote:
> |  (without the 'diff' at the end) you can see the collapsed discussion items?
>
> Yes, in the discussion tab I can.  But of course that is out of context; you just get a little (non-expandable) snippet.
>
> Simon
>
> |  -----Original Message-----
> |  From: Mikolaj Konarski <mikolaj at well-typed.com>
> |  Sent: 14 January 2019 10:30
> |  To: Simon Peyton Jones <simonpj at microsoft.com>
> |  Cc: ghc-devs <ghc-devs at haskell.org>
> |  Subject: Re: GHC | Some refactoring in tcInferApps (!116)
> |
> |  > Looking here
> |  > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> |  > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data=
> |  > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7
> |  > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda
> |  > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0
> |  > I see literally NO discussions with a "toggle discussion" button.  Indeed
> |  if I search for "toggle" I get no hits.
> |
> |  Oh, I see, you are right with respect to the link you cited now.
> |  None of the buttons help, just as you say. I have to navigate back from the
> |  "Changes" to the "Discussion" tab, which gets me to the link you gave
> |  initially
> |  (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40
> |  microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c
> |  d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm
> |  4ag7%2BqBi3c4qpAE7sE%3D&reserved=0)
> |  where the discussions are available, but I can't see them in the context of
> |  the whole diff and none of the buttons there let me extend the view of the
> |  diff. That's quite suboptimal.
> |
> |  Could you confirm that at
> |
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha
> |  skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m
> |  icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd
> |  011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4
> |  ag7%2BqBi3c4qpAE7sE%3D&reserved=0
> |
> |  (without the 'diff' at the end) you can see the collapsed discussion items?
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: screenshot-20190114 at 161655.png
Type: image/png
Size: 2641 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: screenshot-20190114 at 161824.png
Type: image/png
Size: 5791 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: screenshot-20190114 at 171150.png
Type: image/png
Size: 12613 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: screenshot-20190114 at 171141.png
Type: image/png
Size: 11851 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gitlab_ghc.user.js
Type: application/x-javascript
Size: 1000 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190114/e56fcb05/attachment.js>