<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Simon,<br>
</p>
<p>In the diff view, you can click on the avatars on the left to
expand discussions:</p>
<p><img moz-do-not-send="false"
src="cid:part1.E17582DB.274298F8@haskus.fr" alt="" width="178"
height="101"></p>
<p>Or you can click on the "toggle comments for this file" button:</p>
<p><img moz-do-not-send="false"
src="cid:part2.D9953BB2.A74D4E27@haskus.fr" alt="" width="997"
height="62"></p>
<p><br>
</p>
<p><br>
</p>
<p>If you are willing to use GreaseMonkey (Firefox extension) or
TamperMonkey (Chrome/Chromium extension), you can use the attached
script to add new buttons to GitLab UI:<br>
<span class="message-body-wrapper"><span class="message-flex-body"><span
class="message-body devtools-monospace"></span></span></span></p>
<p><img moz-do-not-send="false"
src="cid:part3.9CF91D30.FC1AF3DA@haskus.fr" alt="" width="463"
height="119"></p>
<p><img moz-do-not-send="false"
src="cid:part4.5144A0AF.98359F8A@haskus.fr" alt="" width="469"
height="112"></p>
<p><br>
</p>
<p>Tested on Firefox and Chromium on Linux.</p>
<p>Sylvain<br>
</p>
<br>
<p><span class="message-body-wrapper"><span
class="message-flex-body"><span class="message-body
devtools-monospace"><br>
</span></span></span></p>
<p><br>
</p>
<div class="moz-cite-prefix">On 14/01/2019 11:58, Simon Peyton Jones
via ghc-devs wrote:<br>
</div>
<blockquote type="cite"
cite="mid:AM0PR83MB0308A7CEE656C179CAB1F7A5AD800@AM0PR83MB0308.EURPRD83.prod.outlook.com">
<pre class="moz-quote-pre" wrap="">| (without the 'diff' at the end) you can see the collapsed discussion items?
Yes, in the discussion tab I can. But of course that is out of context; you just get a little (non-expandable) snippet.
Simon
| -----Original Message-----
| From: Mikolaj Konarski <a class="moz-txt-link-rfc2396E" href="mailto:mikolaj@well-typed.com"><mikolaj@well-typed.com></a>
| Sent: 14 January 2019 10:30
| To: Simon Peyton Jones <a class="moz-txt-link-rfc2396E" href="mailto:simonpj@microsoft.com"><simonpj@microsoft.com></a>
| Cc: ghc-devs <a class="moz-txt-link-rfc2396E" href="mailto:ghc-devs@haskell.org"><ghc-devs@haskell.org></a>
| Subject: Re: GHC | Some refactoring in tcInferApps (!116)
|
| > Looking here
| > <a class="moz-txt-link-freetext" href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl</a>
| > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data=
| > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7
| > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda
| > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0
| > I see literally NO discussions with a "toggle discussion" button. Indeed
| if I search for "toggle" I get no hits.
|
| Oh, I see, you are right with respect to the link you cited now.
| None of the buttons help, just as you say. I have to navigate back from the
| "Changes" to the "Discussion" tab, which gets me to the link you gave
| initially
| (<a class="moz-txt-link-freetext" href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h</a>
| askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40
| microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c
| d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm
| 4ag7%2BqBi3c4qpAE7sE%3D&reserved=0)
| where the discussions are available, but I can't see them in the context of
| the whole diff and none of the buttons there let me extend the view of the
| diff. That's quite suboptimal.
|
| Could you confirm that at
|
| <a class="moz-txt-link-freetext" href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha</a>
| skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m
| icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd
| 011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4
| ag7%2BqBi3c4qpAE7sE%3D&reserved=0
|
| (without the 'diff' at the end) you can see the collapsed discussion items?
_______________________________________________
ghc-devs mailing list
<a class="moz-txt-link-abbreviated" href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a>
<a class="moz-txt-link-freetext" href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a>
</pre>
</blockquote>
</body>
</html>