GItLab commenting

[Simon Peyton Jones]

Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question.

My goal is to add a comment to a line in the MR that is not displayed by the MR

If the line is displayed, then yes I can do what you say. But it isn’t!

Zooming off to the repository is not good because while I can get a link to the line, I can’t add a comment; I can only do that in the MR.

Does that make sense?

Simon

From: Julian Leviston <julian at leviston.net>
Sent: 15 February 2019 23:04
To: Simon Peyton Jones <simonpj at microsoft.com>
Cc: GHC developers <ghc-devs at haskell.org>
Subject: Re: GItLab commenting


On 14 Feb 2019, at 8:38 pm, Simon Peyton Jones via ghc-devs <ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>> wrote:

Friends
In reviewing MR!361, I wanted to point out that a Note on line 1481 of a file needed rewriting.  But the patch only modified lines 236 or so.  How can I get it to display line 1481?  (Or, more simply, just display the whole file?)
I can get it to show 10 more lines at a time by clicking the little grey “…” symbols.  But getting 1000 lines down would take 100 clicks – hardly sensible.
Moreover, what if I want to comment on a file that isn’t in the patch at all?
Thanks
Simon

Hi Simon,

Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question.

Warmest regards,
Julian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190218/2125eff3/attachment.html>