GItLab commenting

[Julian Leviston]

> On 18 Feb 2019, at 8:22 pm, Simon Peyton Jones <simonpj at microsoft.com> wrote:
> 
> Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question.
>  
> My goal is to add a comment to a line in the MR that is not displayed by the MR
>  
> If the line is displayed, then yes I can do what you say. But it isn’t! 
>  
> Zooming off to the repository is not good because while I can get a link to the line, I can’t add a comment; I can only do that in the MR.
>  
> Does that make sense?
>  
> Simon
>  

My apologies. I knew I couldn’t surely *actually* be able to help SPJ ;-) <grins> Sorry. Just a big fan.

I spent 30 minutes searching around and discovered the “special gitlab references” section, which I was only vaguely aware of: https://docs.gitlab.com/ee/user/markdown.html#special-gitlab-references <https://docs.gitlab.com/ee/user/markdown.html#special-gitlab-references> but I couldn’t for the life of me find a way to do what we can do in github (quote sections of code into a general comment)

So, I often have this issue in github, too… sometimes I just want to refer to some file that’s not in the PR at all. My solution is usually to write a general comment, and in the comment, I just paste the link of whatever I want to refer to. It’s a bit naff. As you’re implying, we should be able to add a new comment on any file at all in a repository, *at the point in the version history that the repo was at when you wrote the comment*.

Tho, I’m not sure what they’d do to comments that got swept away with rebases and the like (which is probably why it’s not a feature). Might be worth suggesting as a feature.

Sorry I wasn’t more helpful,
Julian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190218/bdcb85d2/attachment.html>