Review of CONTRIBUTORS.md
Ben Gamari
ben at well-typed.com
Thu Sep 28 00:33:30 UTC 2017
Ara Adkins <me at ara.io> writes:
> Hey Ben,
>
> Looks good to me for the most part! I think that you should include a
> link to the Newcomers page [1] as a whole, even though it has some
> overlap with the quick start guide and you’ve included a link to the
> ‘Finding a Ticket’ subsection therein.
>
> I also think that a few more pointers on what is hoped for in a review
> (under ‘Reviewing Patches’) could be helpful for those looking to get
> involved! Code review styles and expectations can vary greatly, so
> some more info here would be good.
>
Thanks Ara! I've tried to address both of these in the patch. Do let me
know if you have further suggestions.
Cheers,
- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20170927/b76ac25c/attachment.sig>
More information about the ghc-devs
mailing list