Review of

Ara Adkins me at
Thu Sep 28 09:36:34 UTC 2017

Hi Ben,

No further suggestions, but the link to the newcomers page is broken, and there is a typo towards the end of the ‘Writing Patches’ section: ‘relative unconversial’ -> ‘relatively uncontroversial’. 

Sorry for the lack of line numbers but I can’t work out how to view the raw file on my phone! 


> On 28 Sep 2017, at 01:33, Ben Gamari <ben at> wrote:
> Ara Adkins <me at> writes:
>> Hey Ben,
>> Looks good to me for the most part! I think that you should include a
>> link to the Newcomers page [1] as a whole, even though it has some
>> overlap with the quick start guide and you’ve included a link to the
>> ‘Finding a Ticket’ subsection therein.
>> I also think that a few more pointers on what is hoped for in a review
>> (under ‘Reviewing Patches’) could be helpful for those looking to get
>> involved! Code review styles and expectations can vary greatly, so
>> some more info here would be good.
> Thanks Ara! I've tried to address both of these in the patch. Do let me
> know if you have further suggestions.
> Cheers,
> - Ben

More information about the ghc-devs mailing list