Review of CONTRIBUTORS.md
me at ara.io
Tue Sep 26 21:41:37 UTC 2017
Looks good to me for the most part! I think that you should include a link to the Newcomers page  as a whole, even though it has some overlap with the quick start guide and you’ve included a link to the ‘Finding a Ticket’ subsection therein.
I also think that a few more pointers on what is hoped for in a review (under ‘Reviewing Patches’) could be helpful for those looking to get involved! Code review styles and expectations can vary greatly, so some more info here would be good.
> On 26 Sep 2017, at 21:58, Ben Gamari <ben at well-typed.com> wrote:
> Hello everyone,
> Today I sat down and wrote a CONTRIBUTORS.md document for the ghc
> repository. This is recommended by GitHub to ensure that contributors
> can easily discover the first steps to contributing to the project.
> Moreover, it provided a nice blank slate to summarize the existing
> contributor documentation.
> It would be greatly appreciated if you could give it  a read-through
> and leave your feedback.
> - Ben
>  https://phabricator.haskell.org/D4037
> ghc-devs mailing list
> ghc-devs at haskell.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the ghc-devs