<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hey Ben,<div><br></div><div>Looks good to me for the most part! I think that you should include a link to the Newcomers page [1] as a whole, even though it has some overlap with the quick start guide and you’ve included a link to the ‘Finding a Ticket’ subsection therein. </div><div><br></div><div>I also think that a few more pointers on what is hoped for in a review (under ‘Reviewing Patches’) could be helpful for those looking to get involved! Code review styles and expectations can vary greatly, so some more info here would be good. </div><div><br></div><div>Best,<br><div id="AppleMailSignature">_ara</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">[1] <a href="https://ghc.haskell.org/trac/ghc/wiki/Newcomers">https://ghc.haskell.org/trac/ghc/wiki/Newcomers</a></div><div><br>On 26 Sep 2017, at 21:58, Ben Gamari <<a href="mailto:ben@well-typed.com">ben@well-typed.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span>Hello everyone,</span><br><span></span><br><span>Today I sat down and wrote a CONTRIBUTORS.md document for the ghc</span><br><span>repository. This is recommended by GitHub to ensure that contributors</span><br><span>can easily discover the first steps to contributing to the project.</span><br><span>Moreover, it provided a nice blank slate to summarize the existing</span><br><span>contributor documentation.</span><br><span></span><br><span>It would be greatly appreciated if you could give it [1] a read-through</span><br><span>and leave your feedback.</span><br><span></span><br><span>Cheers,</span><br><span></span><br><span>- Ben</span><br><span></span><br><span></span><br><span>[1] <a href="https://phabricator.haskell.org/D4037">https://phabricator.haskell.org/D4037</a></span><br><span> <a href="https://github.com/bgamari/ghc/blob/contributing/CONTRIBUTING.md">https://github.com/bgamari/ghc/blob/contributing/CONTRIBUTING.md</a></span><br></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>ghc-devs mailing list</span><br><span><a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a></span><br><span><a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a></span><br></div></blockquote></div></body></html>