Phab: conditional approval

Ben Gamari ben at
Tue Aug 22 13:50:45 UTC 2017

Richard Eisenberg <rae at> writes:

> Hi devs,
> When reviewing a diff on Phab, I can "accept" or "request changes".
> Sometimes, though, I want to do both: I suggest very minor (e.g.,
> typo) changes, but then when these changes are made, I accept. I'm
> leery of making the suggestions and saying "accept", because then
> someone working quickly may merge without noticing the typos. Does
> Phab have such an option?
I have also wanted such an option in the past. In general I think the
accept/request changes responses are a bit coarse-grained: I sometimes
need to hold off on accepting patches merely to ensure that others have
a chance to review before merge.

We could open a ticket with Phacility asking whether a finer mechanism
is something they would entertain.


- Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <>

More information about the ghc-devs mailing list