Phab: conditional approval

Richard Eisenberg rae at cs.brynmawr.edu
Sat Aug 19 02:56:18 UTC 2017


Hi devs,

When reviewing a diff on Phab, I can "accept" or "request changes". Sometimes, though, I want to do both: I suggest very minor (e.g., typo) changes, but then when these changes are made, I accept. I'm leery of making the suggestions and saying "accept", because then someone working quickly may merge without noticing the typos. Does Phab have such an option?

Thanks,
Richard


More information about the ghc-devs mailing list