too many lines too long

C Maeder c.maeder at
Wed Nov 11 12:03:50 UTC 2015

Maybe increasing the limit is not such a bad idea (see scala blog)

"GitHub is the de facto coding standard

125 characters per line is the real de facto coding standard for maximum
line length these days, because this is the maximum number of characters
that you can see in the GitHub diff view."

Cheers Christian

On 09.11.2015 22:02, Richard Eisenberg wrote:
> Hi devs,
> We seem to be uncommitted to the ideal of 80-character lines. Almost every patch on Phab I look through has a bunch of "line too long" lint errors. No one seems to do much about these. And Phab's very very loud indication of a lint error makes reviewing the code harder.
> I like the ideal of 80-character lines. I aim for this ideal in my patches, falling short sometimes, of course. But I think the current setting of requiring everyone to "explain" away their overlong lines during `arc diff` and then trying hard to ignore the lint errors during code review is wrong. And it makes us all inured to more serious lint errors.
> How about this: after `arc diff` is run, it will count the number of overlong lines before and after the patch. If there are more after, have the last thing `arc diff` outputs be a stern telling-off of the dev, along the lines of
>> Before your patch, 15 of the edited lines were over 80 characters.
>> Now, a whopping 28 of them are. Can't you do better? Please?
> Would this be ignored more or followed more? Who knows. But it would sure be less annoying. :)
> What do others think?
> Thanks,
> Richard

More information about the ghc-devs mailing list