Windows build broken again: urgent
johan.tibell at gmail.com
Mon Dec 1 18:01:17 UTC 2014
Yes, ideally this would have been caught by a Windows build bot.
On Mon, Dec 1, 2014 at 4:34 PM, Simon Peyton Jones <simonpj at microsoft.com>
> Indeed. But each bisect takes quite a while. So my attention switches
> and it takes a while to get back. I was hoping some machine might do it
> for me.
> Herbert suggested some commits to revert. I’ll try that first
> *From:* Johan Tibell [mailto:johan.tibell at gmail.com]
> *Sent:* 01 December 2014 09:45
> *To:* Herbert Valerio Riedel
> *Cc:* ghc-devs at haskell.org; Simon Marlow; Simon Peyton Jones
> *Subject:* Re: Windows build broken again: urgent
> In general I think a good course of action when this happens is:
> * Use git bisect to find the offending commit. This works now because we
> moved to submodules.
> * Revert the commit.
> * Push the patch to master and notify the author.
> This style of early rollback will become more important as we grow as it
> puts the onus on fixing on the right person and minimizes negative impact
> on other developers.
> On Dec 1, 2014 9:43 AM, "Herbert Valerio Riedel" <hvriedel at gmail.com>
> Hello Simon,
> On 2014-12-01 at 09:38:37 +0100, Simon Peyton Jones wrote:
> > | Just a hunch... could it have been broken by one of the recent linker-
> > | related patches since Nov 24th?
> > That seems very plausible, yes. But still there's the question of
> > what to do about it.
> a) Empirically: Try locally 'git revert'ing
> and see if your problem goes away, or
> b) Ask Simon Marlow (he either wrote or reviewed those two patches) if
> he sees something odd in those patches that could have broken
> Windows' GHCi...
> ghc-devs mailing list
> ghc-devs at haskell.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the ghc-devs