Windows build broken again: urgent

[Simon Peyton Jones]

Indeed.  But each bisect takes quite a while.  So my attention switches and it takes a while to get back.  I was hoping some machine might do it for me.

Herbert suggested some commits to revert. I’ll try that first

From: Johan Tibell [mailto:johan.tibell at gmail.com]
Sent: 01 December 2014 09:45
To: Herbert Valerio Riedel
Cc: ghc-devs at haskell.org; Simon Marlow; Simon Peyton Jones
Subject: Re: Windows build broken again: urgent


In general I think a good course of action when this happens is:

* Use git bisect to find the offending commit. This works now because we moved to submodules.
* Revert the commit.
* Push the patch to master and notify the author.

This style of early rollback will become more important as we grow as it puts the onus on fixing on the right person and minimizes negative impact on other developers.
On Dec 1, 2014 9:43 AM, "Herbert Valerio Riedel" <hvriedel at gmail.com<mailto:hvriedel at gmail.com>> wrote:
Hello Simon,

On 2014-12-01 at 09:38:37 +0100, Simon Peyton Jones wrote:
> |  Just a hunch... could it have been broken by one of the recent linker-
> |  related patches since Nov 24th?
>
> That seems very plausible, yes.  But still there's the question of
> what to do about it.

 a) Empirically: Try locally 'git revert'ing

     383733b9191a36e2d3f757700842dbc3855911d9

     and/or

     b5e8b3b162b3ff15ae6caf1afc659565365f54a8

     and see if your problem goes away, or

 b) Ask Simon Marlow (he either wrote or reviewed those two patches) if
    he sees something odd in those patches that could have broken
    Windows' GHCi...

Cheers,
  hvr
_______________________________________________
ghc-devs mailing list
ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>
http://www.haskell.org/mailman/listinfo/ghc-devs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20141201/103875c8/attachment.html>