[C2hs] lowercase/C evaluation [was:Don't lowercase...]

Duncan Coutts duncan.coutts at worc.ox.ac.uk
Sun Jan 25 11:36:03 EST 2009


On Sun, 2009-01-25 at 05:03 +0100, Achim Schneider wrote:
> Benedikt Huber <benjovi at gmx.net> wrote:
> 
> > I think we would not want to apply the first part of the patch. The  
> > problem is elsewhere, but I think I've already fixed this before.
> > Could you try whether the second part of the patch alone works fine  
> > with the latest c2hs ?
> > If not, could you give a detailed description of the problem you're  
> > experiencing when not applying the first part ?
> >
> Indeed, it works fine with darcs.

Great.

> Summing up, darcs diff gives me, right now, 
> 
> diff -rN old-c2hs/src/C2HS/CHS.hs new-c2hs/src/C2HS/CHS.hs
> 1105c1105                                                 
> <     adjustCase (c:cs) = toUpper c : map toLower cs      
> ---                                                       
> >     adjustCase (c:cs) = toUpper c : cs                  

Applied. I also added a case for [] which would happen with C names like
"foo__bar".

> diff -rN old-c2hs/src/C2HS/Gen/Bind.hs new-c2hs/src/C2HS/Gen/Bind.hs
> 112a113                                                             
> > import Data.Bits     ((.|.), (.&.))                               
> 2031a2033,2036                                                      
> > applyBin _    COrOp  (IntResult   x)                              
> >                      (IntResult   y) = return $ IntResult (x .|. y) 
> > applyBin _    CAndOp (IntResult   x)                                
> >                      (IntResult   y) = return $ IntResult (x .&. y)

Applied.

Thanks Achim.

So if no more issues come up in the next few days I'll put a release out
on hackage.

Duncan



More information about the C2hs mailing list