[xmonad] Added a new simple layout
Norbert Zeh
nzeh at cs.dal.ca
Sun Mar 15 13:11:20 UTC 2015
Thanks for the pointers, Adam. Updated patch is attached.
Cheers,
Norbert
On Sat, Mar 14, 2015 at 8:18 PM adam vogt <vogt.adam at gmail.com> wrote:
> Hi Norbert,
>
> Would you be willing to change the license to the one contrib uses?
> Otherwise I suppose you should to submit the module to this (unaffiliated)
> project: https://hackage.haskell.org/package/xmonad-contrib-gpl
>
> Also, there's a XMonad.Util.Types.Direction2D that also defines L R U D
> constructors. It would be better to import and use that one instead of data
> Direction.
>
> Thanks,
> Adam
>
>
> On Sat, Mar 14, 2015 at 11:54 AM, Norbert Zeh <nzeh at cs.dal.ca> wrote:
>
>> On Tue, Mar 3, 2015 at 3:39 PM Norbert Zeh <nzeh at cs.dal.ca> wrote:
>>
>>> On Mon, Dec 15, 2014 at 11:50 AM, Brandon Allbery <allbery.b at gmail.com>
>>> wrote:
>>>
>>>> On Fri, Dec 12, 2014 at 12:10 PM, Norbert Zeh <nzeh at cs.dal.ca> wrote:
>>>>>
>>>>> ... and thought I'd share. Patch is attached.
>>>>>
>>>>
>>>> A few nits:
>>>>
>>>> - the comment in XMonad.Layout.Dwindle identifies it as
>>>> XMonad.Layout.Spiral
>>>>
>>>> - consider renaming Rotation, as anyone using your module must also
>>>> import XMonad hiding (Rotation). At the very least, you should document the
>>>> requirement if you're going to keep it, since you export it. Possible
>>>> alternate name: Chirality.
>>>>
>>>
>> Updated patch is attached. Let me know if anything else needs to be
>> fixed.
>>
>> Cheers,
>> Norbert
>>
>> _______________________________________________
>> xmonad mailing list
>> xmonad at haskell.org
>> http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/xmonad/attachments/20150315/749e4fa6/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmonad-layout-dwindle.patch
Type: text/x-patch
Size: 62667 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/xmonad/attachments/20150315/749e4fa6/attachment-0001.bin>
More information about the xmonad
mailing list