[xmonad] mupdf and llpp return from fullscreen

[Carsten Mattner]

On Sun, Jun 24, 2012 at 10:31 AM, Audun Skaugen <audunskaugen at gmail.com> wrote:
> På Fri, 22 Jun 2012 22:27:12 +0200, skrev Carsten Mattner
> <carstenmattner at googlemail.com>:
>
>
>> On Fri, Jun 22, 2012 at 8:57 PM, Carsten Mattner
>> <carstenmattner at googlemail.com> wrote:
>>>
>>> mupdf is configured doFloat and with isFullScreen --> doFullFloat and
>>> smartBorders it
>>> does perfectly go fullscreen. When I press 'f' again to return from
>>> fullscreen the previously
>>> floating mupdf window gets tiled. Same happens for llpp (mupdf based
>>> pdf viewer). No
>>> doFloat rule for llpp configured.
>>>
>>> What might be happening?
>>
>>
>> I'm using handleEventHook = fullscreenEventHook
>> from XMonad.Hooks.EwmhDesktops as otherwise pressing 'f'
>> in mupdf doesn't make it fullscreen.
>> Unsuccessfully tried fullscreenEventHook from XMonad.Layout.Fullscreen.
>
>
> These are the normal behaviour from this setup, because the event hook
> doesn't remember whether the window was tiled before fullscreening. In order
> to get what you seem to want, you should use the XMonad.Layout.Fullscreen
> module.
>
> Note that merely using the fullscreenEventHook from that module isn't
> enough. This hook merely enables the layout modifiers in the module to work.
> To get the behaviour you want, add the event hook and the manage hook from
> the module, and add the fullcsreenFull layout modifier to your layout hook.
> See also the module documentation[1].
>
> [1]:
> http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Layout-Fullscreen.html

I tried to make that works but failed.

It seems that both XMonad.Hooks.EwmhDesktops XMonad.Layout.Fullscreen
provide the same hooks and that it results in a compile error
if I try "eventHook = fullscreenEventHook"

`eventHook' is not a (visible) constructor field name

handleEventHook might be specific to EwmhDesktops.

When I changed the config to not import EwmhDesktops and try to
make the suggested config work pressing 'f' to fullscreen in
mupdf stopped working.

As long as fullscreen'ing works as expected I can remove smartBorders
if that helps. It's ok to display a border even with single window
workspaces.

Thanks for any pointers.