[xmonad] Re: darcs patch: A better solution for choosing whether the tabbar shou...

[Ivan Miljenovic]

David Roundy <droundy at ...> writes:

> 
> On Fri, Apr 11, 2008 at 02:33:37PM -0500, Spencer Janssen wrote:
> > On Fri, Apr 11, 2008 at 07:36:11AM -0700, David Roundy wrote:
> > > On Fri, Apr 11, 2008 at 10:59:10PM +1000,
> ivan.miljenovic at ... wrote:
> > > > Fri Apr 11 22:58:04 EST 2008  Ivan.Miljenovic at ...
> > > >   * A better solution for choosing whether the tabbar should always be
visible.
> > > >   Instead of the previous patch I sent, this patch alters the datatypes
used so that the
> > > >   layouts in Tabbed take in a Bool parameter that sets whether or not
the tabbar should
> > > >   always be shown.  simpleTabbed and simpleTabbedBottom remain unchanged.
> > > >   arossato's, droundy's and sjanssen's configs have been updated to
reflect these changes.
> > > 
> > > Why isn't this Bool a part of the theme?
> > 
> > Themes are used for decorations other than tabbed -- this option doesn't make
> > any sense for these decorations.
> 
> I suppose that's a philosophical point.  But I do object to breaking the
> existing API.  I'd much rather see an extra flag like this added as a new
> function (if we can't stick it in the Theme where it won't hurt anyone), so
> existing configs would continue working.  The fact that this patch had to
> update three configs that don't use the new feature tells me it's broken.

I did it this way because that was how I interpreted sjanssen's suggestions on
#xmonad.  If you want, I can do another patch making these changes to the theme
interface, and setting the boolean flag to false by default.

If I do this though, what should I call the Bool parameter in the theme? 
extraDeco ?