[ghc-steering-committee] Intended meaning of "Needs revision" label

Jakob Brünker jakob.bruenker at gmail.com
Fri Dec 6 17:38:38 UTC 2024


Hi all,

I've so far essentially been using the "Needs revision" label to indicate
that the next concrete step has to be taken by the author, regardless of
how big the changes I suggest are.
After I did this yesterday, VitWW commented
<https://github.com/ghc-proposals/ghc-proposals/pull/621#issuecomment-2523299848>,
essentially saying it's only intended for cases where major rewrites are
required.

>From what I can tell, in past proposals, if relatively minor changes came
up during the shepherding phase, sometimes "Needs revision" was used, and
sometimes not.

Is there a guideline I should follow, or that you tend to follow here?

Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-steering-committee/attachments/20241206/98059fa8/attachment.html>


More information about the ghc-steering-committee mailing list