[ghc-steering-committee] Please review #369: Add sumToTag# primop, Shepherd: Eric

[Eric Seidel]

I applied the changes we suggested and David approved, let's merge!

On Thu, Feb 18, 2021, at 12:10, Joachim Breitner wrote:
> Hi Eric,
> 
> that’s reasonable. I don’t think the authors “own” the PR in a strong
> sense, and fixes that come out of the committee deliberations can be
> applied before merging without their final approval. It’s still nice to
> wait and see if they like it, but not for too long. Unless they
> unticked a box, you should be able to commit to their branch.
> 
> Let me know when the PR is ready!
> 
> Cheers,
> Joachim
> 
> 
> Am Donnerstag, den 18.02.2021, 09:49 -0500 schrieb Eric Seidel:
> > Hi all,
> > 
> > This proposal has been lingering for a while in an all-but-accepted state (thanks Joachim for the nudge!). We had a couple of suggestions to improve the wording of the specification that the author has not responded to. Since they don't affect the content of the proposed change, I suggest we just merge the PR with the suggested improvements.
> > 
> > Eric
> > 
> > On Thu, Oct 29, 2020, at 09:30, Richard Eisenberg wrote:
> > > Yes, I support this.
> > > 
> > > Richard
> > > 
> > > > On Oct 28, 2020, at 5:08 PM, Alejandro Serrano Mena <trupill at gmail.com> wrote:
> > > > 
> > > > I am also fine with the proposal.
> > > > 
> > > > Alejandro
> > > > 
> > > > El mié., 28 oct. 2020 a las 16:13, Spiwack, Arnaud (<arnaud.spiwack at tweag.io>) escribió:
> > > > > The wording of the specification section is still a bit awkward, in my opinion. Other than that, I'm fine with the proposal.
> > > > > 
> > > > > On Wed, Oct 28, 2020 at 12:52 AM Eric Seidel <eric at seidel.io> wrote:
> > > > > > Hi all,
> > > > > > 
> > > > > > I have recommended acceptance of this proposal. It's a simple addition that fills what appears to be a gap in our API around unboxed sums (we already provide `dataToTag#` for lifted types).
> > > > > > 
> > > > > > Please take a look.
> > > > > > 
> > > > > > https://github.com/ghc-proposals/ghc-proposals/pull/369
> > > > > > 
> > > > > > Thanks!
> > > > > > Eric
> > > > > > 
> > > > > > On Thu, Oct 22, 2020, at 03:31, Joachim Breitner wrote:
> > > > > > > Dear Committee,
> > > > > > > 
> > > > > > > this is your secretary speaking:
> > > > > > > 
> > > > > > > Add sumToTag# primop
> > > > > > > has been proposed by David Feuer
> > > > > > > https://github.com/ghc-proposals/ghc-proposals/pull/369
> > > > > > > https://github.com/treeowl/ghc-proposals/blob/sum-to-tag/proposals/0000-sum-to-tag.md
> > > > > > > 
> > > > > > > I’ll propose Eric Seidel as the shepherd.
> > > > > > > 
> > > > > > > Please guide us to a conclusion as outlined in 
> > > > > > > https://github.com/ghc-proposals/ghc-proposals#committee-process
> > > > > > > 
> > > > > > > Thanks,
> > > > > > > Joachim
> > > > > > > -- 
> > > > > > > Joachim Breitner
> > > > > > >   mail at joachim-breitner.de
> > > > > > >   http://www.joachim-breitner.de/
> > > > > > > 
> > > > > > > 
> > > > > > > _______________________________________________
> > > > > > > ghc-steering-committee mailing list
> > > > > > > ghc-steering-committee at haskell.org
> > > > > > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > > > > > > 
> > > > > > _______________________________________________
> > > > > > ghc-steering-committee mailing list
> > > > > > ghc-steering-committee at haskell.org
> > > > > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > > > > _______________________________________________
> > > > > ghc-steering-committee mailing list
> > > > > ghc-steering-committee at haskell.org
> > > > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > > > _______________________________________________
> > > > ghc-steering-committee mailing list
> > > > ghc-steering-committee at haskell.org
> > > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > > 
> > > _______________________________________________
> > > ghc-steering-committee mailing list
> > > ghc-steering-committee at haskell.org
> > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > > 
> > _______________________________________________
> > ghc-steering-committee mailing list
> > ghc-steering-committee at haskell.org
> > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> -- 
> Joachim Breitner
>   mail at joachim-breitner.de
>   http://www.joachim-breitner.de/
> 
> 
> _______________________________________________
> ghc-steering-committee mailing list
> ghc-steering-committee at haskell.org
> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
>