CountDeps

[Rodrigo Mesquita]

Hey Simon

CountDepsParser and CountDepsAST list the closure of the Parser/AST modules dependencies respectively.

This test helps keep in check our goal of making the AST not depend on GHC.* modules (the overarching goal of #21592).
In your case, you’ve extended the closure by adding dependencies to modules which are already in the GHC.* namespace, which is perfectly fine.

Rodrigo

> On 2 Jul 2024, at 09:06, Simon Peyton Jones <simon.peytonjones at gmail.com> wrote:
> 
> Does anyone know what the CountDeps test does?
> 
> I'm getting the failure below in my branch. Should I just accept it?
> 
> I think it's because GHC.Core.FamInstEnv now depends on GHC.Builtin.Types.Literals, a very reasonable dependency
> 
> Thanks
> 
> Simon
> 
> +++ "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsAst.run/CountDepsAst.run.stdout.normalised" 2024-07-01 18:37:33.372548372 +0000
> @@ -2,6 +2,7 @@
> GHC.Builtin.Names
> GHC.Builtin.PrimOps
> GHC.Builtin.Types
> +GHC.Builtin.Types.Literals
> GHC.Builtin.Types.Prim
> GHC.Builtin.Uniques
> GHC.ByteCode.Types
> --- "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsParser.run/CountDepsParser.stdout.normalised" 2024-07-01 18:37:33.393548751 +0000
> +++ "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsParser.run/CountDepsParser.run.stdout.normalised" 2024-07-01 18:37:33.393548751 +0000
> @@ -2,6 +2,7 @@
> GHC.Builtin.Names
> GHC.Builtin.PrimOps
> GHC.Builtin.Types
> +GHC.Builtin.Types.Literals
> GHC.Builtin.Types.Prim
> GHC.Builtin.Uniques
> GHC.ByteCode.Types
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20240702/9facb9c5/attachment.html>