<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Hey Simon<div><br></div><div>CountDepsParser and CountDepsAST list the closure of the Parser/AST modules dependencies respectively.</div><div><br></div><div>This test helps keep in check our goal of making the AST not depend on GHC.* modules (the overarching goal of #21592).</div><div>In your case, you’ve extended the closure by adding dependencies to modules which are already in the GHC.* namespace, which is perfectly fine.</div><div><br></div><div>Rodrigo<br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On 2 Jul 2024, at 09:06, Simon Peyton Jones <simon.peytonjones@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">Does anyone know what the CountDeps test does?</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">I'm getting the failure below in my branch. Should I just accept it?</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">I think it's because GHC.Core.FamInstEnv now depends on GHC.Builtin.Types.Literals, a very reasonable dependency<br></div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Thanks</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Simon</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">
<code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">+++ "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsAst.run/CountDepsAst.run.stdout.normalised" 2024-07-01 18:37:33.372548372 +0000</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">@@ -2,6 +2,7 @@</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Names</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.PrimOps</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Types</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">+GHC.Builtin.Types.Literals</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Types.Prim</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Uniques</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.ByteCode.Types</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">--- "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsParser.run/CountDepsParser.stdout.normalised" 2024-07-01 18:37:33.393548751 +0000</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">+++ "/builds/ghc/ghc/tmp/ghctest-su6yq239/test spaces/testsuite/tests/count-deps/CountDepsParser.run/CountDepsParser.run.stdout.normalised" 2024-07-01 18:37:33.393548751 +0000</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">@@ -2,6 +2,7 @@</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Names</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.PrimOps</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Types</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap">+GHC.Builtin.Types.Literals</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Types.Prim</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><div class="gmail-js-log-line gmail-job-log-line"><span class="gmail-gl-white-space-pre-wrap"> GHC.Builtin.Uniques</span></div><div class="gmail-js-log-line gmail-job-log-line"></div></code><code class="gmail-job-log gmail-gl-display-block"><span class="gmail-gl-white-space-pre-wrap"> GHC.ByteCode.Types</span></code>
</div></div>
_______________________________________________<br>ghc-devs mailing list<br>ghc-devs@haskell.org<br>http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br></div></blockquote></div><br></div></body></html>