What to do with gmp wasm fixes
ben at well-typed.com
Tue May 24 13:22:16 UTC 2022
Cheng Shao <cheng.shao at tweag.io> writes:
> Hi all,
> The ghc wasm32-wasi build needs to patch gmp. Currently, our working
> branch uses a fork of gmp-tarballs that includes the patch into the
> tarball, but at some point we need to upstream it. What's the best way
> to add these fixes?
> - Send a PR to gmp-tarballs, including our patch (doesn't alter
> behavior on native archs) and the updated tarball build script
> - Don't touch gmp-tarballs, use "system" gmp, so the wasm32-wasi gmp
> build process is decoupled from ghc build
> - Give up gmp completely, only support native bignum for wasm32.
I think it would be reasonable to include your patch in `gmp-tarballs`;
please do open an MR. However I do also think we should make an attempt
to upstream it so that eventually we can drop the patch locally.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 487 bytes
Desc: not available
More information about the ghc-devs