advice on minor cleanups?

Ben Gamari ben at smart-cactus.org
Mon Nov 8 18:53:19 UTC 2021


Norman Ramsey <nr at cs.tufts.edu> writes:

> All,
>
> It appears that `runHscBackendPhase` returns a tuple that include an
> element of type `Maybe Linkable` but that in practice is always
> `Nothing`.  I'm thinking of removing this element from the tuple,
> which would also entail simplifying the type of value constructor
> `T_HscBackend` for the `TPhase` type.  Simplifying the code seems like
> a good thing, but perhaps there is a reason to leave well enough
> alone?  Please advise me.
>
Hi Norman,

In cases like this I generally just try to push the change through, open
a merge request, and note my uncertainty in the merge request
description, and let review and CI sort it out.

Cheers,

- Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20211108/88a7ec0b/attachment.sig>


More information about the ghc-devs mailing list