Merge request merge timing

Ben Gamari ben at well-typed.com
Tue Dec 21 17:23:51 UTC 2021


Hello all,

Recently there have been a few instances where merge requests were
merged extremely quickly (e.g. within an hour of the MR being opened).
While prompt review is a good thing, we also want to make sure that all
potentially interested reviewers have an opportunity to comment.

In this vein, I propose that we wait at least 24 hours from the time an
MR is opened before sending it to Marge. I have documented this to the
merge-request review guidelines on the Wiki [1].

Cheers,

- Ben


[1] https://gitlab.haskell.org/ghc/ghc/-/wikis/gitlab/merge-requests
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20211221/37d397db/attachment.sig>


More information about the ghc-devs mailing list