Changes in GHC API modularity with the "Encode shape information in PMOracle" MR

[Sebastian Graf]

Shayne,

out of curiosity, could you find out which of the three modules DsMonad,
FamInst and TcSimplify lead to the blowup? If it's not too much of a
hassle, that is.
These are the only imports of PmOracle that aren't already exported from
ghc-lib-parser.

Cheers,
Sebastian

Am Mo., 16. Sept. 2019 um 22:38 Uhr schrieb Shayne Fletcher <
shayne.fletcher at daml.com>:

> Hi Sebastian,
>
> On Mon, Sep 16, 2019 at 5:23 PM Sebastian Graf <sgraf1337 at gmail.com>
> wrote:
>
>> Hi Shayne,
>>
>> Sorry to hear that! We didn't consider modularity at all and I would be
>> happy to try to refactor in a way that would allow `ghc-lib-parser` to be
>> properly separated again.
>> I'm fairly certain that I didn't directly touch anything parser related,
>> but apparently the new cyclic import of PmOracle within TcRnTypes (which is
>> also exposed from `ghc-lib-parser`) pulled in the other half of GHC.
>> I'll see if I can fix that tomorrow, if only by extracting a separate
>> `Types`-style module.
>>
>>
> That sounds awesome. Tremendous. Thank-you! Please feel free to reach out
> to me if there's anything I can do to help your analysis[*]!
>
> [*] For the record, the procedure for calculating the `ghc-lib-parser`
> modules is a little complicated by there needing to be some generated
> equivalents of `.hsc` files present for this to work but the procedure is
> at the end of the day just `ghc -M` invoked over `Parser.hs`.
>
>
>> Cheers,
>> Sebastian
>>
>
> Fingers crossed and all the best!
>
> --
> *Shayne Fletcher*
> Language Engineer */* +1 917 699 7663
> *Digital Asset* <https://digitalasset.com/>, creators of *DAML
> <https://daml.com/>*
>
> This message, and any attachments, is for the intended recipient(s) only,
> may contain information that is privileged, confidential and/or proprietary
> and subject to important terms and conditions available at
> http://www.digitalasset.com/emaildisclaimer.html. If you are not the
> intended recipient, please delete this message.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190917/57609dfa/attachment.html>