MR titles

chessai . chessai1996 at gmail.com
Wed May 8 11:28:38 UTC 2019


I agree that this is the way to go. This is part of our contributing guide
at work, for the reasons you mentioned. Additionally it helps avoid the
need to read the MR's contents (comments/code) before going into it, since
reading relevant tickets is almost always something you want to do.

Thanks

On Wed, May 8, 2019, 4:51 AM Simon Peyton Jones via ghc-devs <
ghc-devs at haskell.org> wrote:

> Friends
>
> In this MR <https://gitlab.haskell.org/ghc/ghc/merge_requests/908>, Vlad
> includes the number of the ticket it fixes *in the title of the MR.*
>
> That is so helpful:
>
>    - It links the MR back to the issue
>    - And does so in large font (screen shot below)
>    - And the link is clickable, even in the title.
>
> I suggest we document this in our GHC-best-practice guide, and get
> everyone to do it.
>
> Would you agree
>
> Simon
>
>
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190508/f5d4534b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 14040 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190508/f5d4534b/attachment-0001.jpg>


More information about the ghc-devs mailing list