<div dir="auto"><div>I agree that this is the way to go. This is part of our contributing guide at work, for the reasons you mentioned. Additionally it helps avoid the need to read the MR's contents (comments/code) before going into it, since reading relevant tickets is almost always something you want to do.</div><div dir="auto"><br></div><div dir="auto">Thanks<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Wed, May 8, 2019, 4:51 AM Simon Peyton Jones via ghc-devs <<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="#0563C1" vlink="#954F72">
<div class="m_-2135759482994495219WordSection1">
<p class="MsoNormal">Friends<u></u><u></u></p>
<p class="MsoNormal">In <a href="https://gitlab.haskell.org/ghc/ghc/merge_requests/908" target="_blank" rel="noreferrer">
this MR</a>, Vlad includes the number of the ticket it fixes <b>in the title of the MR.</b><u></u><u></u></p>
<p class="MsoNormal">That is so helpful:<u></u><u></u></p>
<ul style="margin-top:0cm" type="disc">
<li class="m_-2135759482994495219MsoListParagraph" style="margin-left:0cm">It links the MR back to the issue<u></u><u></u></li><li class="m_-2135759482994495219MsoListParagraph" style="margin-left:0cm">And does so in large font (screen shot below)<u></u><u></u></li><li class="m_-2135759482994495219MsoListParagraph" style="margin-left:0cm">And the link is clickable, even in the title.<u></u><u></u></li></ul>
<p class="MsoNormal">I suggest we document this in our GHC-best-practice guide, and get everyone to do it.<u></u><u></u></p>
<p class="MsoNormal">Would you agree<u></u><u></u></p>
<p class="MsoNormal">Simon<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><img border="0" width="546" height="151" style="width:5.6916in;height:1.575in" id="m_-2135759482994495219Picture_x0020_1" src="cid:image001.jpg@01D50583.988DEB70"><u></u><u></u></p>
</div>
</div>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank" rel="noreferrer">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div></div></div>