More GitLab questions

Ben Gamari ben at smart-cactus.org
Thu Jan 10 18:18:39 UTC 2019


Simon Peyton Jones via ghc-devs <ghc-devs at haskell.org> writes:

>   * When looking at a comment on a MR, I see some snippet of code. How
>     can I see what module that snippet is in? Apart from scrolling up to
>     find the file header - being careful not to miss it and scroll into
>     the previous file.
>
Sigh, yes. This is an unfortunate lack in the UI that I have noticed as
well. I drew upstream's attention to it a while back and they indicated [1]
that they will be fixing this in the next 3-4 releases. I have raised a
signal with upstream indicating that this is causing us considerable
pain in hopes that they prioritize it [2].

[1] https://gitlab.com/gitlab-org/gitlab-ce/issues/53356
[2] https://gitlab.com/gitlab-org/gitlab-ce/issues/55039#note_130613037

>   * When looking a comment, there's a little button to skip to the
>     next unresolved comment. Good. But if I respond to the comment
>     (without resolving it), that little button disappears. How can I
>     find the next unresolved comment?

Hmm, that is strange. I can't reproduce this. I see the button remain at
the end of the discussion, even after I leave a comment [1]. Perhaps
this [2] is the issue you are seeing?

[1] https://gitlab.haskell.org/ghc/ghc/merge_requests/97/diffs#note_2368
[2] https://gitlab.com/gitlab-org/gitlab-ce/issues/21689

Cheers,

- Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190110/10da5f24/attachment.sig>


More information about the ghc-devs mailing list