Notes from Ben's "contribute to ghc" discussion

Ben Gamari ben at
Sat Sep 24 21:37:09 UTC 2016

Phyx <lonetiger at> writes:

>>> ยท        Auto-push: Ability to push to Phab and have it committed
>>> automatically if it validates.
>> \o/
> How would this work? Could there be a cooldown period? e.g. commits sit a
> day before being auto-committed?
> Validate really only validates Linux x86_64. The situation is already quite
> dire for other architectures and OSes,
> I fear making it worse by not allowing people time to object.
The solution here is to extend Harbormaster coverage, which is on my
list anyways. My priorities is roughly,

> Would this be a per person setting? This just raises so many questions. And
> I don't quite see what problem it's solving
> because presumably code is tested before it's put on Phab isn't it?

I think the we'd want to restrict this to Diffs submitted by
contributors who already possess commit bits and specifically include a
"no-review" tag in the summary. The idea here is to provide an
alternative to pushing directly to master, extending the coverage of
Harbormaster without inconveniencing contributors.


- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <>

More information about the ghc-devs mailing list