[commit: ghc] wip/generics-flip: Flip around imports of GHC.Generics (cb12bdf)

Simon Peyton Jones simonpj at microsoft.com
Mon Jul 18 21:52:37 UTC 2016


I don’t object to this, but I suspect that it's just covering up some other bug.

Simon

-----Original Message-----
From: ghc-commits [mailto:ghc-commits-bounces at haskell.org] On Behalf Of git at git.haskell.org
Sent: 18 July 2016 14:57
To: ghc-commits at haskell.org
Subject: [commit: ghc] wip/generics-flip: Flip around imports of GHC.Generics (cb12bdf)

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/generics-flip
Link       : https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fghc.haskell.org%2ftrac%2fghc%2fchangeset%2fcb12bdf942df5e61771d69bbb6049f3b23ed580c%2fghc&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c00c068de6b96437c02c008d3af136ead%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=20bLDBfKU23EKDZOmV1qGcs4x8k1JwDbFUwEFXEOYsw%3d

>---------------------------------------------------------------

commit cb12bdf942df5e61771d69bbb6049f3b23ed580c
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Mon Jul 18 15:54:16 2016 +0200

    Flip around imports of GHC.Generics
    
    Previously we had,
    
        GHC.Generics    imports    GHC.Ptr
        Data.Monoid     imports    GHC.Generics
        Data.Foldable   imports    GHC.Generics
        Data.Foldable   imports    Data.Monoid
        Prelude         imports    Data.Foldable
    
    Unfortunately this meant that any program importing Prelude (essentially
    all programs) would end up pulling in GHC.Generics and GHC.Ptr
    unnecessarily.
    
    Hopefully helps #12367.


>---------------------------------------------------------------

cb12bdf942df5e61771d69bbb6049f3b23ed580c
 libraries/base/Data/Foldable.hs | 36 ----------------------
 libraries/base/Data/Monoid.hs   | 19 +++++-------
 libraries/base/GHC/Generics.hs  | 67 +++++++++++++++++++++++++++++++++++++++--
 3 files changed, 72 insertions(+), 50 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc cb12bdf942df5e61771d69bbb6049f3b23ed580c
_______________________________________________
ghc-commits mailing list
ghc-commits at haskell.org
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.haskell.org%2fcgi-bin%2fmailman%2flistinfo%2fghc-commits&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c00c068de6b96437c02c008d3af136ead%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6pgOX2cCExS7BYtk%2bNb9f4tTJQ7uuEWy5KfsmDig91Q%3d


More information about the ghc-devs mailing list