Linker.c broken

[Simon Marlow]

I will fix it, sorry about this.  Unfortunately I can't really add a
Windows validate into my workflow because it would mean rebooting my laptop
into Windows and not doing anything else for several hours.  We need some
CI support for Windows - Ben/Austin any thoughts on this?

On 4 July 2016 at 09:28, Simon Peyton Jones <simonpj at microsoft.com> wrote:

> That was it.
>
> Simon M: would you care to fix? Or should I push a revert?
>
> Simon
>
> |  -----Original Message-----
> |  From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of
> |  Edward Z. Yang
> |  Sent: 02 July 2016 01:02
> |  To: ghc-devs <ghc-devs at haskell.org>
> |  Subject: Re: Linker.c broken
> |
> |  I'm guessing it's:
> |
> |  commit 6377757918c1e7f63638d6f258cad8d5f02bb6a7
> |  Author: Simon Marlow <marlowsd at gmail.com>
> |  Date:   Wed Jun 29 21:50:18 2016 +0100
> |
> |      Linker: some extra debugging / logging
> |
> |  which added ghci_find.
> |
> |  Edward
> |
> |  Excerpts from Simon Peyton Jones via ghc-devs's message of 2016-07-01
> |  18:51:20 -0400:
> |  > Aargh!  Windows is broken /again/.   Some mess-up in Linker.c.
> |  > I have not yet tried reverting recent patches.  Might someone fix
> |  please?
> |  > It’s really helpful to validate on Windows when making RTS changes.
> |  > Simon
> |  >
> |  >
> |  >
> |  > rts\Linker.c: In function 'ghci_find':
> |  >
> |  >
> |  >
> |  > rts\Linker.c:1482:52: error:
> |  >
> |  >      error: pointer type mismatch in conditional expression [-
> |  Werror]
> |  >
> |  >                                   oc->archiveMemberName : oc-
> |  >fileName);
> |  >
> |  >                                                         ^
> |  >
> |  >
> |  >
> |  > rts\Linker.c:1480:28: error:
> |  >
> |  >      error: format '%ls' expects argument of type 'wchar_t *', but
> |  argument 3 has type 'void *' [-Werror=format=]
> |  >
> |  >                      debugBelch("%p is in %" PATH_FMT, addr,
> |  >
> |  >                                 ^
> |  >
> |  > "inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -
> |  optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-
> |  Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-
> |  Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-
> |  Wnested-externs -optc-Wredundant-decls -optc-Iincludes -optc-
> |  Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-
> |  Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -
> |  optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common -optc-
> |  Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-
> |  frame-pointer -optc-g -optc-fno-omit-frame-pointer -optc-g -optc-O0 -
> |  optc-DRtsWay=\"rts_debug\" -optc-DWINVER=0x06000100 -static -optc-
> |  DDEBUG -ticky -DTICKY_TICKY  -O0 -H64m -Wall -fllvm-fill-undef-with-
> |  garbage    -Werror -Iincludes -Iincludes/dist -Iincludes/dist-
> |  derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -
> |  Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint      -i -
> |  irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -
> |  Irts/dist/build/./autogen           -O2 -O0    -Wnoncanonical-monad-
> |  instances  -c rts/RaiseAsync.c -o rts/dist/build/RaiseAsync.debug_o
> |  >
> |  >
> |  >
> |  > rts\Linker.c:1483:28: error:
> |  >
> |  >      error: format '%lx' expects argument of type 'long unsigned
> |  int', but argument 3 has type 'long long unsigned int' [-
> |  Werror=format=]
> |  >
> |  >                      debugBelch(", section %d, offset %lx\n", i,
> |  >
> |  >                                 ^
> |  >
> |  >
> |  >
> |  > In file included from rts\Linker.c:13:0: error:
> |  >
> |  > rts\Linker.c: In function 'ocTryLoad':
> |  >
> |  >
> |  >
> |  > rts\Linker.c:2563:55: error:
> |  >
> |  >      error: pointer type mismatch in conditional expression [-
> |  Werror]
> |  >
> |  >                                      oc->archiveMemberName : oc-
> |  >fileName));
> |  >
> |  >                                                            ^
> |  >
> |  >
> |  >
> |  > includes\Rts.h:300:53: error:
> |  >
> |  >      note: in definition of macro 'IF_DEBUG'
> |  >
> |  >      #define IF_DEBUG(c,s)  if (RtsFlags.DebugFlags.c) { s; }
> |  >
> |  >                                                          ^
> |  >
> |  >
> |  >
> |  > rts\Linker.c:2561:33: error:
> |  >
> |  >      error: format '%ls' expects argument of type 'wchar_t *', but
> |  argument 2 has type 'void *' [-Werror=format=]
> |  >
> |  >          IF_DEBUG(linker, debugBelch("Resolving %" PATH_FMT "\n",
> |  >
> |  >                                      ^
> |  >
> |  >
> |  >
> |  > includes\Rts.h:300:53: error:
> |  >
> |  >      note: in definition of macro 'IF_DEBUG'
> |  >
> |  >      #define IF_DEBUG(c,s)  if (RtsFlags.DebugFlags.c) { s; }
> |  >
> |  >                                                          ^
> |  >
> |  > cc1.exe: all warnings being treated as errors
> |  >
> |  > `gcc.exe' failed in phase `C Compiler'. (Exit code: 1)
> |  >
> |  > rts/ghc.mk:255: recipe for target 'rts/dist/build/Linker.debug_o'
> |  failed
> |  >
> |  > make[1]: *** [rts/dist/build/Linker.debug_o] Error 1
> |  >
> |  > make[1]: *** Waiting for unfinished jobs....
> |  >
> |  > Makefile:129: recipe for target 'all' failed
> |  >
> |  > make: *** [all] Error 2
> |  >
> |  > /cygdrive/c/code/HEAD$
> |  _______________________________________________
> |  ghc-devs mailing list
> |  ghc-devs at haskell.org
> |  https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.h
> |  askell.org%2fcgi-bin%2fmailman%2flistinfo%2fghc-
> |  devs&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c5be115baccfd40d
> |  0352a08d3a20c257d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ZJFHPuP
> |  zkPfac4Upu3w6r4bSawNwxbV4p%2fr%2f69vqh2o%3d
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20160704/453c918c/attachment.html>