ok to do reformatting commits?
eir at cis.upenn.edu
Wed Nov 25 03:23:05 UTC 2015
Thanks for volunteering to do this work, but I'm afraid now is a terrible time to do it. I know of three significant patches that are about to be committed, and your reformatting would cause quite a few merge conflicts. If there is a lull between a feature freeze and a ghc-8.0 fork, that would be the ideal time, to my mind.
That said, I remain unconvinced that a rigid commitment to 80-char lines is in our best interest. My personal vote is to continue to have 80 characters as a guideline but to keep the current practice of allowing programmer discretion.
On Nov 24, 2015, at 10:14 PM, Evan Laforge <qdunkan at gmail.com> wrote:
> When I was doing a recent patch, I was annoyed by lint errors about
>> 80 lines when I was just conforming to the existing style. To avoid
> cluttering my commit with unrelated changes, I decided to fix the
> lints in a formatting-only commit afterwards. Looking in the
> archives, I see there was some recent discussion about this, but I
> didn't see anyone volunteering to just go wrap a bunch of files, or
> saying that they didn't want anyone to do this (usual reason being
> cluttering the history, which as a rationale to not do formatting only
> changes never sat too well with me).
> Would anyone mind if I went and wrapped a bunch of files, say
> typecheck/*.hs? This seems simpler than either constant hassling from
> arc or coming up with more elaborate rules for arc. I would have to
> make some formatting decisions, so likely to some eyes I would be
> messing some stuff up, but since there's no real standard that is
> probably unavoidable.
> ghc-devs mailing list
> ghc-devs at haskell.org
More information about the ghc-devs