too many lines too long
eir at cis.upenn.edu
Fri Nov 13 15:20:17 UTC 2015
Could you add your comment to the ticket I've created? https://ghc.haskell.org/trac/ghc/ticket/11082
As for case conventions: The parts of GHC I play in have a fairly reliable convention: underscores for local things (both local variables and non-exported helper functions) and camel case for exported things. It's a nice convention that I've used elsewhere. This is not rigorously applied, but it's pretty good.
On Nov 13, 2015, at 10:01 AM, Jan Stolarek <jan.stolarek at p.lodz.pl> wrote:
> My view on this is:
> Firstly, I hate explaining myself to Arcanist. When prompted to explain the reason for too long
> lines I typically enter "wontfix" without thinking too much.
> Secondly, I really don't like how warnings clutter code reviews.
> I have my Emacs highlight text beyond 80th column with a really ugly colour, so I strive real hard
> to maintain 80-column limit whenever possible. But sometimes fitting in that limit is nearly
> impossible: imagine being in a let nested in a do-notation nested in a guard nested in a where
> clause. Approx. 15-20 columns are lost for the indentation. Nevertheless I would support
> introducing a hard limit on having no more than 80 columns.
> PS. It makes me really sad that we don't have any coding convention for GHC: we mix camelCase with
> underscore_case, indentation is inconsistent (good thing we at least got rid of tabs!),
> whitespace usage is inconsistent, etc. I could make this list very long.
> Politechnika ÅÃ³dzka
> Lodz University of Technology
> TreÅÄ tej wiadomoÅci zawiera informacje przeznaczone tylko dla adresata.
> JeÅ¼eli nie jesteÅcie PaÅstwo jej adresatem, bÄ
> dÅº otrzymaliÅcie jÄ
> przez pomyÅkÄ
> prosimy o powiadomienie o tym nadawcy oraz trwaÅe jej usuniÄcie.
> This email contains information intended solely for the use of the individual to whom it is addressed.
> If you are not the intended recipient or if you have received this message in error,
> please notify the sender and delete it from your system.
> ghc-devs mailing list
> ghc-devs at haskell.org
More information about the ghc-devs