DPH tests

[Kostiantyn Rybnikov]

Would be a strong +1 from me, since it would mean:

1. We could script in the "Plan B" from here [0] and add it to default
"./validate" to have less work for people to either search via Wiki or get
recommendations in Trac tickets to notice these additional tests
2. We would notice things like currently-broken hmatrix installation and
previously-broken dph- ones immediately.
3. Dead-tests and dead-code is always an unfortunate thing to have.

[0]:
https://ghc.haskell.org/trac/ghc/wiki/Debugging/InstallingPackagesInplace

On Mon, Apr 6, 2015 at 2:10 PM, Carter Schonwald <carter.schonwald at gmail.com
> wrote:

> Relatedly, might it be a good idea for at least the phab build bot tests
> to enable stuff like the tests that use vector and other widely used
> packages?
> On Apr 6, 2015 3:46 AM, "Thomas Miedema" <thomasmiedema at gmail.com> wrote:
>
>> Hi Konstantine,
>>
>> thanks for investigating this. I updated the wiki by removing those
>> packages from the list.
>>
>> The testsuite driver simply skips tests that depend on packages that are
>> not installed (dph-* in this case). I don't know what to about those tests
>> though, as dph is unmaintained and not in a working state.
>>
>> I someone really wanted to, they could try building ghc with
>> `BUILD_DPH=yes` in build.mk, then `cd testsuite/tests/dph`, remove all
>> `reqlib` calls to the deprecated dph-* packages in the `.T` files, run
>> `make test`, and see what happens.
>>
>> Please note that running the full testsuite in general results in lots of
>> failed tests. The continuous integration system only runs `make fasttest`.
>>
>> Thomas
>>
>> On Mon, Apr 6, 2015 at 8:52 AM, Konstantine Rybnikov <k-bx at k-bx.com>
>> wrote:
>>
>>> Hi!
>>>
>>> There’s «Additional Packages» section [0] which lists packages that need
>>> to be installed in order to run full testsuite. But I couldn’t install
>>> dph-* ones, first errors I was getting were regular cabal-constraint ones.
>>> I wrote an author Ben Lippmeier, but he replied that dph-* packages were
>>> obsolete and not maintained anymore. I grepped and saw that all tests are
>>> under testsuite/dph folder. So: does GHC still run them at all? Should we
>>> edit wiki? Or edit test-suite?
>>>
>>> Thanks!
>>>
>>> [0]:
>>> https://ghc.haskell.org/trac/ghc/wiki/Building/RunningTests/Running#AdditionalPackages
>>>
>>>
>>> _______________________________________________
>>> ghc-devs mailing list
>>> ghc-devs at haskell.org
>>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>>
>>>
>>
>> _______________________________________________
>> ghc-devs mailing list
>> ghc-devs at haskell.org
>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20150406/3e31e7c6/attachment-0001.html>