Again: Uniques in GHC

Johan Tibell johan.tibell at gmail.com
Mon Oct 6 10:06:43 UTC 2014


On Mon, Oct 6, 2014 at 11:58 AM, <p.k.f.holzenspies at utwente.nl> wrote:

>  - The export-list of Unique has some comments stating that function X is
> only exported for module Y, yet is used elsewhere. This may be because
> these comments do not show up in haddock etc. leading some people to think
> they're up for general use. In my refactoring, I'm sticking the restriction
> in the function name, so it's no longer mkUniqueGrimily, but rather
> mkUniqueOnlyForUniqSupply (making the name even longer should discourage
> their use more). If at all possible, these should be removed altogether
> asap.
>

Since you're touching this code base it would be a terrific time to add
some Haddocks! (We recently decided, on the ghc-devs@ list, that all new
top-level entities, i.e. functions, data types, and classes, should have
Haddocks.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20141006/6cb27d3f/attachment.html>


More information about the ghc-devs mailing list