GitHub pull requests

[Carter Schonwald]

@ben cool!

yeah... the phab/arc workflow is probably the easiest part of the compiler
patch work flow, heck, unlike a lot of projects you get ci for free! :)
but thigns that make it easier are always good

On Sun, Oct 5, 2014 at 1:03 AM, Ben Gamari <bgamari.foss at gmail.com> wrote:

> Richard Eisenberg <eir at cis.upenn.edu> writes:
>
> > I've just finished reading this:
> http://www.reddit.com/r/haskell/comments/2hes8m/the_ghc_source_code_contains_1088_todos_please/
> >
> > For better or worse, I don't read reddit often enough to hold a
> > conversation there, so I'll ask my question here: Is there a way we
> > can turn GitHub pull requests into Phab code reviews? I'm thinking of
> > something like this:
> >
> > ...
> >
> I'm still quite unsure of how many people exist who,
>
>  * find a bug they need to fix,
>  * are willing to dig into the GHC codebase and fix it,
>  * clean up their fix enough to submit upstream, and
>  * take the initiative to send the fix upstream
>
> and yet aren't willing to take the five (twenty?) minutes to familiarize
> themselves with Phabricator and the arc toolchain.
>
> That being said, I'm all for lowering barriers. I started to write up a
> quick hack [1] to implement this sort of process. It's a bit late at the
> moment so I'll just put it up here for comment for the time being. It's
> a bit messy, the security implications are haven't been considered at
> all, and half of it is pseudo-code at best. That being said, it's a
> start and if someone picks it up and finishes it before I wake up
> tomorrow I won't be offended.
>
> Cheers,
>
> - Ben
>
>
> [1] https://gist.github.com/bgamari/72020a6186be205d0f33
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20141005/0744250d/attachment.html>