[commit: ghc] master: Always quote arguments to removeFiles (fixes Windows install). (1a3247f)

Gabor Greif ggreif at gmail.com
Fri Feb 22 18:26:25 CET 2013


On 2/22/13, Geoffrey Mainland <gmainlan at microsoft.com> wrote:
> Repository : ssh://darcs.haskell.org//srv/darcs/ghc
>
> On branch  : master
>
> http://hackage.haskell.org/trac/ghc/changeset/1a3247f6a5d98c15139e8650c88a61284a786731
>
>>---------------------------------------------------------------
>
> commit 1a3247f6a5d98c15139e8650c88a61284a786731
> Author: Geoffrey Mainland <gmainlan at microsoft.com>
> Date:   Fri Feb 22 15:26:55 2013 +0000
>
>     Always quote arguments to removeFiles (fixes Windows install).
>
>     Thanks to Daniel Pratt <colorblinddad at gmail.com> for pointing out the
> failure
>     and fix.
>
...
>  install_ghc_post: install_bins
> -	$(call removeFiles,$(DESTDIR)$(bindir)/ghc.exe)
> +	$(call removeFiles,"$(DESTDIR)$(bindir)/ghc.exe")

This should be

$(call removeFiles,"$(DESTDIR)$(bindir)/$(CrossCompilePrefix)ghc.exe")

Cheers,

    Gabor

>  	"$(MV)" -f $(DESTDIR)$(bindir)/ghc-stage$(INSTALL_GHC_STAGE).exe
> $(DESTDIR)$(bindir)/$(CrossCompilePrefix)ghc.exe
>  endif
>

> http://www.haskell.org/mailman/listinfo/ghc-commits
>



More information about the ghc-devs mailing list