New Git-commit-message -> Trac-ticket interaction

Simon Marlow marlowsd at gmail.com
Tue Aug 13 14:16:30 CEST 2013


On 10/08/13 10:57, Herbert Valerio Riedel wrote:

> The command verbs currently recognized for referencing a ticket are
> currently:
>
> | addressing addresses re references refs see Trac
>
> ...and the verbs currently recognized for referencing *and* closing a
> ticket are
>
> | close closed closes fix fixed fixes
>
> Consequently, if you just write "Fixes Trac #1234" in your commit (which
> occurs quite often in the git history), this will only reference the
> ticket but *not* close the ticket.
>
> If closing from commits is not desired or causes problems, we can move
> the close/fix verbs into the "reference-only" set of verbs and be done
> with it.

One reason that we didn't enable this feature before was that we often 
want to move the ticket into the merge state after committing the fix.

So perhaps we should either have a new keyword ("mergefix"?) for fixes 
we want to merge, or we should not have the auto-close behaviour.

Cheers,
	Simon





More information about the ghc-devs mailing list