[Git][ghc/ghc][wip/ghci-primcall] minor cleanups

[Luite Stegeman (@luite)]

Luite Stegeman pushed to branch wip/ghci-primcall at Glasgow Haskell Compiler / GHC


Commits:
2fbcf50d by Luite Stegeman at 2023-01-08T23:35:38+09:00
minor cleanups

- - - - -


3 changed files:

- compiler/GHC/ByteCode/Asm.hs
- compiler/GHC/StgToByteCode.hs
- compiler/GHC/StgToCmm/Foreign.hs


Changes:

=====================================
compiler/GHC/ByteCode/Asm.hs
=====================================
@@ -595,7 +595,7 @@ maxPrimCallNativeStackSize = 255
   use to convert arguments between the native calling convention and the
   interpreter.
 
-  See Note [GHCi tuple layout] for more information.
+  See Note [GHCi and native call registers] for more information.
  -}
 mkNativeCallInfoSig :: Platform -> NativeCallInfo -> Word32
 mkNativeCallInfoSig platform NativeCallInfo{..}


=====================================
compiler/GHC/StgToByteCode.hs
=====================================
@@ -1065,7 +1065,6 @@ layoutNativeCall :: Profile
                     )
 layoutNativeCall profile call_type start_off arg_ty reps =
   let platform = profilePlatform profile
-      -- XXX is NativeReturn correct for both NativeTupleReturn and NativePrimCall?
       (orig_stk_bytes, pos) = assignArgumentsPos profile
                                                  0
                                                  NativeReturn


=====================================
compiler/GHC/StgToCmm/Foreign.hs
=====================================
@@ -349,7 +349,7 @@ emitRestoreRegs = do
 -- bytecode interpreter.
 --
 -- The "live registers" bitmap corresponds to the list of registers given by
--- 'actualArgRegsCover', with the least significant bit indicating liveness of
+-- 'allArgRegsCover', with the least significant bit indicating liveness of
 -- the first register in the list.
 --
 -- Each register is saved to a stack slot of one or more machine words, even



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2fbcf50d1142f5bb81076e43092286cfa6b3df54

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2fbcf50d1142f5bb81076e43092286cfa6b3df54
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230108/877abd9c/attachment-0001.html>