[commit: ghc] master: Don't suppress unimplemented type family warnings with DeriveAnyClass (3f05e5f)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/3f05e5f6becc2f7174898726b6f027105b12a780/ghc

>---------------------------------------------------------------

commit 3f05e5f6becc2f7174898726b6f027105b12a780
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Sat Aug 12 15:46:44 2017 -0400

    Don't suppress unimplemented type family warnings with DeriveAnyClass
    
    Summary:
    For some asinine reason, we were suppressing warnings when
    deriving associated type family instances with `DeriveAnyClass`. That seems
    like a bad idea. Let's not do that.
    
    Along the way, I noticed that the error contexts associated with these
    newly emitted warnings were less than ideal, so I did some minor refactoring
    to improve the story there.
    
    Fixes #14094
    
    Test Plan: ./validate
    
    Reviewers: bgamari, austin
    
    Subscribers: rwbarton, thomie
    
    GHC Trac Issues: #14094
    
    Differential Revision: https://phabricator.haskell.org/D3828


>---------------------------------------------------------------

3f05e5f6becc2f7174898726b6f027105b12a780
 compiler/typecheck/TcClassDcl.hs                   | 27 ++++++++++++++++++----
 compiler/typecheck/TcDeriv.hs                      | 22 ++++++++++--------
 compiler/typecheck/TcInstDcls.hs                   |  2 +-
 testsuite/tests/deriving/should_compile/T14094.hs  | 13 +++++++++++
 .../tests/deriving/should_compile/T14094.stderr    | 26 +++++++++++++++++++++
 testsuite/tests/deriving/should_compile/all.T      |  1 +
 .../tests/deriving/should_fail/T10598_fail3.stderr |  7 +++---
 .../tests/deriving/should_fail/T8165_fail2.stderr  |  7 +++---
 8 files changed, 82 insertions(+), 23 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 3f05e5f6becc2f7174898726b6f027105b12a780