[commit: ghc] wip/perf-testsuite: Small changes to address Ben's comments (1ee0a7f)
git at git.haskell.org
git at git.haskell.org
Thu Aug 10 08:43:53 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/perf-testsuite
Link : http://ghc.haskell.org/trac/ghc/changeset/1ee0a7ff16c4d6714785a02eeceb24360b8220be/ghc
>---------------------------------------------------------------
commit 1ee0a7ff16c4d6714785a02eeceb24360b8220be
Author: Jared Weakly <jweakly at pdx.edu>
Date: Tue Jul 18 17:35:34 2017 -0700
Small changes to address Ben's comments
Signed-off-by: Jared Weakly <jweakly at pdx.edu>
>---------------------------------------------------------------
1ee0a7ff16c4d6714785a02eeceb24360b8220be
testsuite/driver/runtests.py | 5 +++++
testsuite/driver/testlib.py | 1 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/testsuite/driver/runtests.py b/testsuite/driver/runtests.py
index 25643e9..796a2c5 100644
--- a/testsuite/driver/runtests.py
+++ b/testsuite/driver/runtests.py
@@ -307,6 +307,11 @@ else:
summary(t, sys.stdout, config.no_print_summary)
+ # This here is loading up all of the git notes into memory.
+ # It's most likely in the wrong spot and I haven't fully fleshed out
+ # where exactly I'm putting this and how I'm refactoring the performance
+ # test running logic.
+ # Currently this is useful for debugging, at least.
if config.use_git_notes:
note = subprocess.check_output(["git","notes","--ref=perf","append","-m", "\n".join(config.accumulate_metrics)])
parse_git_notes('perf') # Should this be hardcoded? Most likely not...
diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py
index a24ee6c..8fc3ed7 100644
--- a/testsuite/driver/testlib.py
+++ b/testsuite/driver/testlib.py
@@ -1086,7 +1086,6 @@ def stats( name, way, stats_file ):
# Check -t stats info
def checkStats(name, way, stats_file, range_fields):
-
full_name = name + '(' + way + ')'
result = passed()
More information about the ghc-commits
mailing list