[commit: ghc] master: Show: Restore redundant parentheses around records (1448f8a)

Thu Mar 24 15:12:40 UTC 2016

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/1448f8ab2379452312f1f74f6d5ba4de8ad3d47e/ghc

>---------------------------------------------------------------

commit 1448f8ab2379452312f1f74f6d5ba4de8ad3d47e
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Thu Mar 24 10:54:11 2016 +0100

    Show: Restore redundant parentheses around records

    As discussed in #2530 we are going to continue to produce parentheses
    here in order to preserve compatibility with previous GHC releases. It
    was found that dropped parentheses would break some testsuites which
    compared against output from Show. This has been documented in the users
    guide.

    This reverts commit 5692643c9d17e746327588cd6157a923642b7975.

    Test Plan: Validate

    Reviewers: hvr, austin

    Subscribers: thomie

    Differential Revision: https://phabricator.haskell.org/D2027

    GHC Trac Issues: #2350

>---------------------------------------------------------------

1448f8ab2379452312f1f74f6d5ba4de8ad3d47e
 compiler/hsSyn/HsExpr.hs                                  |  6 ++----
 compiler/typecheck/TcGenDeriv.hs                          |  2 --
 docs/users_guide/bugs.rst                                 | 15 +++++++++++++++
 testsuite/tests/codeGen/should_run/T7953.stdout           |  4 ++--
 testsuite/tests/deriving/should_run/drvrun020.stdout      |  2 +-
 .../tests/ghc-api/annotations-literals/literals.stdout    |  6 +++---
 6 files changed, 23 insertions(+), 12 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1448f8ab2379452312f1f74f6d5ba4de8ad3d47e