[commit: ghc] ghc-8.0: Unconditionally handle TH known key names. (745bdd8)
git at git.haskell.org
git at git.haskell.org
Fri Mar 11 14:21:45 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : ghc-8.0
Link : http://ghc.haskell.org/trac/ghc/changeset/745bdd88f9e4f9c85d46e84c58d6799bf71725b7/ghc
>---------------------------------------------------------------
commit 745bdd88f9e4f9c85d46e84c58d6799bf71725b7
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date: Thu Feb 25 21:47:30 2016 +0100
Unconditionally handle TH known key names.
Previously, we didn't add Template Haskell key names to the list
of known uniques when building a stage 1 compiler. But with
f16ddcee0c64a92ab911a7841a8cf64e3ac671fd we may refer to TH
names even in stage 1, and this was causing uniques to not
be setup properly.
Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
Test Plan: validate and run stage1 test suite
Reviewers: osa1, austin, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1520
GHC Trac Issues: #10382
(cherry picked from commit bbfff2298d7ea7d0f4e590f8137f43a651e8f61d)
>---------------------------------------------------------------
745bdd88f9e4f9c85d46e84c58d6799bf71725b7
compiler/main/HscMain.hs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/compiler/main/HscMain.hs b/compiler/main/HscMain.hs
index b069345..c34b6fd 100644
--- a/compiler/main/HscMain.hs
+++ b/compiler/main/HscMain.hs
@@ -98,12 +98,12 @@ import Type ( Type )
import {- Kind parts of -} Type ( Kind )
import CoreLint ( lintInteractiveExpr )
import VarEnv ( emptyTidyEnv )
-import THNames ( templateHaskellNames )
import Panic
import ConLike
import Control.Concurrent
#endif
+import THNames ( templateHaskellNames )
import Module
import Packages
import RdrName
@@ -216,9 +216,7 @@ allKnownKeyNames -- where templateHaskellNames are defined
= all_names
where
all_names = knownKeyNames
-#ifdef GHCI
++ templateHaskellNames
-#endif
namesEnv = foldl (\m n -> extendNameEnv_Acc (:) singleton m n n)
emptyUFM all_names
More information about the ghc-commits
mailing list