[commit: ghc] ghc-8.0: Fix #11624, cannot declare hs-boot if already one in scope. (88a86f1)

git at git.haskell.org git at git.haskell.org
Fri Mar 11 14:21:43 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.0
Link       : http://ghc.haskell.org/trac/ghc/changeset/88a86f126f0fb2439b832927d51fd6d6445135b7/ghc

>---------------------------------------------------------------

commit 88a86f126f0fb2439b832927d51fd6d6445135b7
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Fri Mar 11 10:37:26 2016 +0100

    Fix #11624, cannot declare hs-boot if already one in scope.
    
    I'm not sure if this fix is the "right way" to do it, but
    it solves the proximal problem, which is that lookupBindGroupOcc
    was picking out the wrong renaming for hs-boot signatures,
    which then lead to an interface file error.
    
    Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: simonpj, hvr, austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1963
    
    GHC Trac Issues: #11624
    
    (cherry picked from commit fc16690a536b74e7af72e963599471474e3df603)


>---------------------------------------------------------------

88a86f126f0fb2439b832927d51fd6d6445135b7
 compiler/rename/RnBinds.hs                         | 22 +++++++---------------
 compiler/rename/RnEnv.hs                           |  4 ++--
 compiler/rename/RnSource.hs                        |  8 +++++++-
 testsuite/tests/driver/sigof02/all.T               |  8 ++++----
 testsuite/tests/driver/sigof02/sigof02dmt.stderr   | 15 ++++++++-------
 testsuite/tests/driver/sigof02/sigof02dt.stderr    | 15 ++++++++-------
 testsuite/tests/rename/should_compile/T11624.hs    |  4 ++++
 .../tests/rename/should_compile/T11624.hs-boot     |  3 +++
 .../tests/rename/should_compile/T11624.stderr      |  3 +++
 testsuite/tests/rename/should_compile/T11624a.hs   |  4 ++++
 testsuite/tests/rename/should_compile/all.T        |  1 +
 11 files changed, 51 insertions(+), 36 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 88a86f126f0fb2439b832927d51fd6d6445135b7


More information about the ghc-commits mailing list