[commit: ghc] wip/ghc-8.0-det: Refactor validity checking for type/data instances (308c21f)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.0-det
Link       : http://ghc.haskell.org/trac/ghc/changeset/308c21fc4c3cf08854d186c10963c51eab5c3db7/ghc

>---------------------------------------------------------------

commit 308c21fc4c3cf08854d186c10963c51eab5c3db7
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Jan 22 16:40:55 2016 +0000

    Refactor validity checking for type/data instances
    
    I found that there was some code duplication going on,
    so I've put more into the shared function checkValidFamPats.
    
    I did some refactoring in checkConsistentFamInst too,
    preparatory to #11450; the error messages change a little
    but no change in behaviour.


>---------------------------------------------------------------

308c21fc4c3cf08854d186c10963c51eab5c3db7
 compiler/typecheck/TcInstDcls.hs                   |   9 +-
 compiler/typecheck/TcTyClsDecls.hs                 |   2 +
 compiler/typecheck/TcValidity.hs                   | 154 ++++++++++++---------
 .../indexed-types/should_fail/SimpleFail2a.stderr  |  11 +-
 4 files changed, 101 insertions(+), 75 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 308c21fc4c3cf08854d186c10963c51eab5c3db7